Hide ordering a bit
#1597
Hide ordering a bit
#1597
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1597 +/- ##
=======================================
Coverage 86.98% 86.98%
=======================================
Files 114 114
Lines 29686 29686
=======================================
Hits 25823 25823
Misses 3863 3863 ☔ View full report in Codecov by Sentry. |
|
I also like the idea of differentiating between Nemo and Singular monomial orderings by using different names! |
joschmitt
force-pushed
the
js/ordering
branch
from
892c741
to
ffc9a55
Compare
|
This is the way to go as decided in today's "Kaiserslautern meeting". |
|
The failing test is "expected", right? |
|
It's at least not the first time I've seen it. We should probably open a issue about it |
|
Please merge this whenever we are ready for the next cascade of breaking releases. |
joschmitt
force-pushed
the
js/ordering
branch
from
8679373
to
37de2c4
Compare
|
I removed the deprecations now. If we keep them in, we would also deprecate |
|
The auto-merge will not work. At least, the "matching" checks haven't started for days now. |
I renamed the
orderingkeyword in polynomial rings tointernal_orderingas a first attempt in the direction of oscar-system/Oscar.jl#3040 and a basis for discussion how this should proceed (if at all).CC @YueRen (because you seemed interested...)